Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
|
Thanks @Kevsy - I've commited your 2 requests. |
| message: | ||
| type: string | ||
| description: A human-readable description of what the event represents |
There was a problem hiding this comment.
@bigludo7 in sim-swap @hdamker commented to go back to the previous model camaraproject/SimSwap#229 (comment)
we should do the same here
But for me, @fernandopradocabrillo, the request in the order was for the |
@bigludo7 now you got me, I though the problem was the order of the properties because they are not aligned with the examples |
Let ask to our Guru - Herbert are we good to go for this one for M4 ? the |
@bigludo7 @fernandopradocabrillo The order should be same in
The correct order is The reference is now in https://github.com/camaraproject/Commonalities/pull/517/files (the fix which aligns the order with the API Design Guide and which will go into Commonalities r3.4.) You had exactly the right order in v2.0.0 of number-verification. To avoid confusion of developers about an unnecessary change between NumberVerification v2.0.0 and v2.1.0 I strongly recommend that you fix the order also in ErrorInfo.properties before the M4 release, so that it is again the same as in v2.0.0 |
|
@fernandopradocabrillo @hdamker I reversed the order. A new PR was not required as main was in the right order. |
Kevsy
left a comment
There was a problem hiding this comment.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Publication of Fall'25 M4 public release of number-verification v2.1.0
Which issue(s) this PR fixes:
Fixes #214
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.